Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_servicecatalog_product (compliment PR 2064) #4980

Closed
wants to merge 13 commits into from

Conversation

trung
Copy link
Contributor

@trung trung commented Jun 25, 2018

This is the continued work from PR #2064 taking in comments from @radeksimko

$ make testacc TESTARGS='-run=TestAccAWSServiceCatalogProduct_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSServiceCatalogProduct_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSServiceCatalogProduct_basic
--- PASS: TestAccAWSServiceCatalogProduct_basic (10.66s)
=== RUN   TestAccAWSServiceCatalogProduct_updateTags
--- PASS: TestAccAWSServiceCatalogProduct_updateTags (17.41s)
=== RUN   TestAccAWSServiceCatalogProduct_updateProvisioningArtifactBasic
--- PASS: TestAccAWSServiceCatalogProduct_updateProvisioningArtifactBasic (23.06s)
=== RUN   TestAccAWSServiceCatalogProduct_updateProvisioningArtifactForceNew
--- PASS: TestAccAWSServiceCatalogProduct_updateProvisioningArtifactForceNew (19.89s)
=== RUN   TestAccAWSServiceCatalogProduct_import
--- PASS: TestAccAWSServiceCatalogProduct_import (10.78s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       81.820s

@ghost ghost added the size/XL Managed by automation to categorize the size of a PR. label Jun 25, 2018
@bflad bflad added new-resource Introduces a new resource. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels Jun 25, 2018
@trung
Copy link
Contributor Author

trung commented Aug 6, 2018

@radeksimko @bflad is there any update on this PR? There are more PRs related to service catalog to be raised once this is merged.

@ozbillwang
Copy link

@radeksimko

Can you review and approve this PR?

@ozbillwang
Copy link

@trung

Do you have other servicecatalog related resource PRs ready as well?

#1663 (comment)

@trung
Copy link
Contributor Author

trung commented Nov 2, 2018

No PRs have been raised as we need this to be reviewed merged first as changes in this may cause changes in the other ones. Here are those in the pipeline:

  • aws_servicecatalog_product_provisioning resource
  • aws_servicecatalog_product data source
  • aws_servicecatalog_launch_path data source
  • aws_servicecatalog_provisiong_artifact data source

All are super useful and we are using it constantly

CC @johnmcteague

@ozbillwang
Copy link

ozbillwang commented Nov 3, 2018

@trung

Thanks for the updates. Seems this is not a small task. These resources need work together, wait for them all merged takes time.

Any chance to set it as a new provider first and slowly get them merged into aws provider later? This new provider can be under your account. With this way, we can start using it.

@jordan-evans
Copy link

I'm very interested in this additional functionality around Service Catalog. Any ideas on the way forward here?

@aeschright aeschright requested a review from a team June 25, 2019 21:31
@AndyMoore
Copy link
Contributor

any chance of getting this updated and reviewed?

@trung @bflad @ryndaniels

@Eerk1975
Copy link

Eerk1975 commented Mar 4, 2020

what can we do to get this pull request in motion?
we would like to contribute, but need to know what's missing.

@teamterraform
Copy link

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

Base automatically changed from master to main January 23, 2021 00:55
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:55
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 28, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants